refactor(schematics): use parse5 for finding inputs and outputs #12524
Conversation
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
| import {findAttributeInElementWithAttrs, findAttributeInElementWithTag} from './elements'; | ||
|
|
||
| /** Finds the specified Angular @Input in the given elements with tag name. */ | ||
| export function findInputsInElementWithTag(html: string, name: string, tagNames: string[]) { |
There was a problem hiding this comment.
name -> inputName?
(similar for other functions)
| import {findAttributeInElementWithAttrs, findAttributeInElementWithTag} from './elements'; | ||
|
|
||
| /** Finds the specified Angular @Input in the given elements with tag name. */ | ||
| export function findInputsInElementWithTag(html: string, name: string, tagNames: string[]) { |
There was a problem hiding this comment.
I would change the all of the function names from InElement to OnElement
| } | ||
|
|
||
| /** Finds the specified Angular @Output in elements that have one of the specified attributes. */ | ||
| export function findAllOutputsInElWithAttr(html: string, name: string, attrs: string[]) { |
There was a problem hiding this comment.
This should have element written out to be consistent with all the other functions (even if it makes the line wrap 😉)
There was a problem hiding this comment.
Yeah I actually forgot about that function at all. Should be findOutputsOnElementWithAttr.
| import {DefaultTreeDocument, DefaultTreeElement, parseFragment} from 'parse5'; | ||
|
|
||
| /** | ||
| * Parses a HTML fragment and travers all AST nodes in order find elements that include the |
devversion
force-pushed
the
refactor/schematics-html-parse5
branch
from
c983971 to
1c141e9
Compare
|
@jelbourn Addressed your feedback. Thanks |
| * Parses a HTML fragment and traverses all AST nodes in order find elements that | ||
| * include the specified attribute. | ||
| */ | ||
| export function findElementWithAttribute(html: string, attributeName: string) { |
There was a problem hiding this comment.
This one is still InElement instead of OnElement
There was a problem hiding this comment.
I guess you mean that this should be Elements and the functions below should use OnElement instead of InElement. I've made those changes.
* No longer constructs a complex and unreadable RegExp for finding Angular inputs and outputs. Since we declared `parse5` as a dependency for the schematics, we could use `parse5`. * Adds types for parse5 as dev dependency since parse5 is often used in the schematics.
devversion
force-pushed
the
refactor/schematics-html-parse5
branch
from
1c141e9 to
8e9c7e0
Compare
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
parse5as a dependency for the schematics, we could useparse5.Note: Adding tests for all those things when walking through all rules and updating them.