fix(mat-selection-list): do not allow ctrl + a when mat-selection-list is disabled

[steve-todorov]

Fixes #12542

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

[steve-todorov]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

[crisbeto]

Rather than checking whether the list is disabled, these should loop through the options and check whether each individual one is disabled. That would catch both the case where individual ones are disabled and the entire list is disabled.

[steve-todorov]

Yes, that indeed sounds like a better solution.

[crisbeto]

This should be a const since it isn't being re-assigned.

[steve-todorov]

Fixed, thanks! :)

[devversion]

This check should be removed now. Since we now check each individual option, this check just makes the !option.disabled condition a noop.

I'd format it like this:

this.options.forEach(option => {
  if (!option.disabled && option._setSelected(isSelected)) {
    hasChanged = true;
  }
});

Thanks for your work on this! Good catch.

[crisbeto]

Also this shouldn't be done in this method, but rather inline inside the keydown handler. This won't allow for all options to be selected/deselected programmatically.

[steve-todorov]

@crisbeto could you please have a look again when you have some time? I was thinking to add a disabled check in the MatListOption#toggle() method, but decided this is enough because you might want to manually toggle it programmatically for some unknown reason. Let me know your thoughts.

[ngbot]

Hi @steve-todorov! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

[annieyw]

@crisbeto do we still want to proceed with this change?

[crisbeto]

This was resolved in #18885. Closing.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}