Skip to content

test(autocomplete): fix failing test #12587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2018
Merged

test(autocomplete): fix failing test #12587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 21 additions & 15 deletions src/lib/autocomplete/autocomplete.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1508,40 +1508,46 @@ describe('MatAutocomplete', () => {

it('should fall back to above position when requested if options are added while ' +
'the panel is open', fakeAsync(() => {
let fixture = createComponent(AutocompleteWithOnPushDelay);
let fixture = createComponent(SimpleAutocomplete);
fixture.componentInstance.states = fixture.componentInstance.states.slice(0, 1);
fixture.componentInstance.filteredStates = fixture.componentInstance.states.slice();
fixture.detectChanges();

let inputEl = fixture.debugElement.query(By.css('input')).nativeElement;
let inputReference = fixture.debugElement.query(By.css('.mat-form-field-flex')).nativeElement;

// Push the element down so it has a little bit of space, but not enough to render.
inputReference.style.bottom = '10px';
inputReference.style.bottom = '75px';
inputReference.style.position = 'fixed';

// Focus the input to load the deferred options.
dispatchFakeEvent(inputEl, 'focusin');
tick(1000);

fixture.detectChanges();
tick();
zone.simulateZoneExit();
fixture.detectChanges();

const inputBottom = inputReference.getBoundingClientRect().bottom;
const panel = overlayContainerElement.querySelector('.mat-autocomplete-panel')!;
const panelTop = panel.getBoundingClientRect().top;
let panel = overlayContainerElement.querySelector('.mat-autocomplete-panel')!;
let inputRect = inputReference.getBoundingClientRect();
let panelRect = panel.getBoundingClientRect();

expect(Math.floor(inputBottom))
.toEqual(Math.floor(panelTop),
expect(Math.floor(panelRect.top))
.toBe(Math.floor(inputRect.bottom),
`Expected panel top to be below input before repositioning.`);

for (let i = 0; i < 20; i++) {
fixture.componentInstance.filteredStates.push({code: 'FK', name: 'Fake State'});
fixture.detectChanges();
}

// Request a position update now that there are too many suggestions to fit in the viewport.
fixture.componentInstance.trigger.updatePosition();

const inputTop = inputReference.getBoundingClientRect().top;
const panelBottom = panel.getBoundingClientRect().bottom;
inputRect = inputReference.getBoundingClientRect();
panelRect = panel.getBoundingClientRect();

expect(Math.floor(inputTop))
.toEqual(Math.floor(panelBottom),
expect(Math.floor(panelRect.bottom))
.toBe(Math.floor(inputRect.top),
`Expected panel to fall back to above position after repositioning.`);
tick();
}));

it('should not throw if a panel reposition is requested while the panel is closed', () => {
Expand Down