Skip to content

feat(tabs): align with 2018 material design spec #12605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 9, 2018

Aligns the tabs component with the latest Material design spec and adds the ability to align the tab labels in the middle or the end of the container.

angular_material_-_google_chrome_2018-08-09_21-49-20
angular_material_-_google_chrome_2018-08-09_21-49-31

@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Aug 9, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 9, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 10, 2018
@ngbot
Copy link

ngbot bot commented Aug 10, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: build" is failing
    failure status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Aug 14, 2018
@mmalerba
Copy link
Contributor

@crisbeto I think we want to just not make the letter-spacing change here, it just doesn't look good in pretty much any of the apps with screenshot tests

@jelbourn
Copy link
Member

+1 - I looked at the letter-spacing changes with Miles and they really just look awful across the board in real apps.

Aligns the tabs component with the latest Material design spec and adds the ability to align the tab labels in the middle or the end of the container.
@crisbeto
Copy link
Member Author

I've reverted the letter spacing changes.

@mmalerba mmalerba merged commit 0c5598c into angular:master Sep 23, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
Aligns the tabs component with the latest Material design spec and adds the ability to align the tab labels in the middle or the end of the container.

![angular_material_-_google_chrome_2018-08-09_21-49-20](https://user-images.githubusercontent.com/4450522/43922278-7ddc9b7e-9c1e-11e8-9a16-86c4427efcf8.png)
![angular_material_-_google_chrome_2018-08-09_21-49-31](https://user-images.githubusercontent.com/4450522/43922279-7dfe19fc-9c1e-11e8-98a2-e4606a01a6ab.png)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants