Skip to content

fix(button-toggle): clickable area not stretching when custom width is set #12642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 21, 2018
Merged

fix(button-toggle): clickable area not stretching when custom width is set #12642

merged 1 commit into from
Aug 21, 2018

Conversation

crisbeto
Copy link
Member

Fixes the button toggle's clickable area not stretching, if the element is stretched beyond its initial width.

Fixes #8432.

@crisbeto
fix(button-toggle): clickable area not stretching when custom width i…
6cdfb4f 
…s set

Fixes the button toggle's clickable area not stretching, if the element is stretched beyond its initial width.

Fixes angular#8432.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 12, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner August 12, 2018 10:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 12, 2018
josephperrott
josephperrott approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@josephperrott josephperrott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephperrott josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 13, 2018
jelbourn
jelbourn approved these changes Aug 13, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn merged commit ecf8b0d into angular:master Aug 21, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
@crisbeto @jelbourn
fix(button-toggle): clickable area not stretching when custom width i…
70aca02 
…s set (#12642)

Fixes the button toggle's clickable area not stretching, if the element is stretched beyond its initial width.

Fixes #8432.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@josephperrott josephperrott josephperrott approved these changes

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MatButtonToggle doesn't support width's change
4 participants
@crisbeto @jelbourn @josephperrott @googlebot