refactor(focus-monitor): support monitoring ElementRef #12712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows for an `ElementRef` to be monitored by the `FocusMonitor`. This makes it more convenient, because most of the time we're dealing with `ElementRef` anyway.
crisbeto
requested review from
amcdnl,
andrewseguin,
devversion,
jelbourn,
josephperrott and
mmalerba
as code owners
googlebot
added
the
cla: yes
mmalerba
approved these changes
Aug 17, 2018
| monitor(element: HTMLElement, checkChildren: boolean = false): Observable<FocusOrigin> { | ||
| monitor(element: HTMLElement, checkChildren?: boolean): Observable<FocusOrigin>; | ||
|
|
||
| /** |
There was a problem hiding this comment.
do we have to repeat the docs comment?
There was a problem hiding this comment.
AFAIK otherwise it won't display for all signatures in the IDE autocompletion.
jelbourn
added
target: minor
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Sep 4, 2018
Looks like something that was missed in angular#12712. For consistency with `monitor` and `stopMonitoring`, accepts an `ElementRef` in `focusVia`.
jelbourn
pushed a commit
that referenced
this pull request
Sep 6, 2018
Looks like something that was missed in #12712. For consistency with `monitor` and `stopMonitoring`, accepts an `ElementRef` in `focusVia`.
jelbourn
pushed a commit
that referenced
this pull request
Sep 11, 2018
Looks like something that was missed in #12712. For consistency with `monitor` and `stopMonitoring`, accepts an `ElementRef` in `focusVia`.
jelbourn
pushed a commit
that referenced
this pull request
Sep 11, 2018
Looks like something that was missed in #12712. For consistency with `monitor` and `stopMonitoring`, accepts an `ElementRef` in `focusVia`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for an
ElementRefto be monitored by theFocusMonitor. This makes it more convenient, because most of the time we're dealing withElementRefanyway.