fix(form-field): remove leading space for asterisk #12727
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
the
target: major
googlebot
added
the
cla: yes
crisbeto
approved these changes
Aug 18, 2018
devversion
added
action: merge
devversion
added
target: patch
|
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
devversion
added
pr: needs rebase
and removed
action: merge
* In order to align with the 2018 Material Design guidelines, the leading space before the required asterisk should be removed. Fixes angular#12721
devversion
force-pushed
the
fix/form-field-space-asterisk
branch
from
1b37a84 to
9d86560
Compare
devversion
added
action: merge
devversion
force-pushed
the
fix/form-field-space-asterisk
branch
from
9d86560 to
17132a3
Compare
devversion
added
blocked
|
Currently blocked on #13911 which should fix the Bazel tests. |
|
@jelbourn should we still do this? I assume it's not really a priority anymore and eventually will be fixed by the MDC prototype. Closing for now. let me know if I should re-open. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the specs and by looking at MDC, there should be no leading space. In addition to removing the space, MDC seems to still shift the asterisk by
1px(potentially to make it look better on higher resolutions; I can notice a little improvement in UX with 4k as well).P2 because it should be merged prioritized for V7 beta. (spec alignment)
Fixes #12721