Skip to content

docs: update links to Material Design spec #12804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

EdricChan03
Copy link
Contributor

@EdricChan03 EdricChan03 commented Aug 23, 2018

For color palettes, link to the archived spec since there isn't an equivalent in the 2018 revision.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed labels Aug 23, 2018
@ngbot
Copy link

ngbot bot commented Aug 23, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    pending status "ci/circleci: build" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn
Copy link
Member

Commit message fixup:

docs: update links to Material Design spec

For color palettes, link to the archived spec since there isn't an equivalent in the 2018 revision. 

@EdricChan03 EdricChan03 force-pushed the docs/update-material-spec-links branch from 55e88f8 to 45fc504 Compare August 23, 2018 15:38
For color palettes, link to the archived spec since there isn't an equivalent in the 2018 revision.
@EdricChan03 EdricChan03 force-pushed the docs/update-material-spec-links branch from 45fc504 to a5bba23 Compare August 23, 2018 15:39
@EdricChan03 EdricChan03 changed the title chore: update Material Design spec URLs docs: update links to Material Design spec Aug 23, 2018
@jelbourn jelbourn merged commit 4c2a9f2 into angular:master Aug 24, 2018
@EdricChan03 EdricChan03 deleted the docs/update-material-spec-links branch August 24, 2018 04:46
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
For color palettes, link to the archived spec since there isn't an equivalent in the 2018 revision.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation merge: fix commit message When the PR is merged, rewrites/fixups of the commit messages are needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants