fix(drag-drop): item not being restored to its initial DOM position when using custom preview #12808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen using custom preview When a `cdkDrag` item is picked up, we save its `nextSibling` so we know where to put it once the user has stopped dragging. This logic gets thrown off when we use a custom preview element and it ends up leaving the element in the wrong place in the DOM. These changes ensure that the element is restored to its old position correctly.
crisbeto
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
|
I've marked the PR as safe, because the drag&drop still hasn't been in a release since we moved it to the CDK. |
jelbourn
approved these changes
Aug 23, 2018
src/cdk/drag-drop/drag.ts
Outdated
| @@ -337,6 +341,8 @@ export class CdkDrag<T = any> implements OnDestroy { | |||
| // while moving the existing elements in all other cases. | |||
| this.element.nativeElement.style.display = ''; | |||
|
|
|||
| console.log('cleaning up'); | |||
…iew-not-restoring
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
cdkDragitem is picked up, we save itsnextSiblingso we know where to put it once the user has stopped dragging. This logic gets thrown off when we use a custom preview element and it ends up leaving the element in the wrong place in the DOM. These changes ensure that the element is restored to its old position correctly.