fix(input): do not focus input element twice #12851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently if a user clicks on a input, the element receives focus and the `click` event bubbles up. Once it reaches the `<mat-form-field>`, the click event will cause the `onContainerClick` method to be invoked. This method then manually focused the input element (again). Resulting in unexpected behavior for time inputs in Firefox. Fixes angular#12849
devversion
added
the
target: patch
googlebot
added
the
cla: yes
mmalerba
reviewed
Aug 27, 2018
| // Do not re-focus the input element if the element is already focused. Otherwise it can happen | ||
| // that someone clicks on a time input and the cursor resets to the "hours" field while the | ||
| // "minutes" field was actually clicked. See: https://github.com/angular/material2/issues/12849 | ||
| if (!this.focused) { |
There was a problem hiding this comment.
Do we need similar logic for other MatFormFieldControl components (e.g. select, chips)
There was a problem hiding this comment.
It guess it wouldn't hurt. There might be also people that use chips with a time input.
I can update it tomorrow (or have a follow-up PR)
There was a problem hiding this comment.
Just checked. The chip list already has a proper check for that. Please have another look.
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Aug 28, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clickevent bubbles up. Once it reaches the<mat-form-field>, the click event will cause theonContainerClickmethod to be invoked. This method then manually focused the input element (again). Resulting in unexpected behavior for time inputs in Firefox.Note: There is no good way to test this behavior because we cannot dispatch a click event that sets
focusand also explicitly selects theminutefield of a time input. E2E tests don't work either because we run against Chrome headless and not Firefox.Fixes #12849