feat(ng-add): respect project default inlineStyle, inlineTemplate and spec option value #12888
Conversation
devversion
added
pr: merge safe
target: major
googlebot
added
the
cla: yes
| if (!options.styleext) { | ||
| options.styleext = determineDefaultStyleExt(project); | ||
| } | ||
| setDefaultSchematicOptions(project, options); |
There was a problem hiding this comment.
@jelbourn I'm very unhappy with that function name. Do you have any better ideas?
There was a problem hiding this comment.
How about
options = {...getDefaultComponentOptions(project), ...options};There was a problem hiding this comment.
That would have been perfect. Unfortunately the options will look something like: {spec: undefined} and therefore wouldn't be replaced by the default component options.
I've went with something like that:
// Add the default component option values to the options if an option is not explicitly
// specified but a default component option is available.
Object.keys(options)
.filter(optionName => options[optionName] == null && defaultComponentOptions[optionName])
.forEach(optionName => options[optionName] = defaultComponentOptions[optionName]);
| fallbackValue: T): T | null { | ||
| if (project.schematics && | ||
| project.schematics['@schematics/angular:component'] && | ||
| project.schematics['@schematics/angular:component'][optionName] !== undefined) { |
There was a problem hiding this comment.
Done. Please have another look.
| if (!options.styleext) { | ||
| options.styleext = determineDefaultStyleExt(project); | ||
| } | ||
| setDefaultSchematicOptions(project, options); |
There was a problem hiding this comment.
How about
options = {...getDefaultComponentOptions(project), ...options};| * by looking at the stored schematic options for `@schematics/angular:component` in the | ||
| * CLI workspace configuration. | ||
| */ | ||
| function getDefaultSchematicOption<T>(project: WorkspaceProject, optionName: string, |
… spec option value If developers create a new Angular CLI project, options like `--skipTests`, `--inlineTemplate` or `--inlineStyle` can be specified. These options will be stored in the workspace config file and will be respected if someone generates another component on the existing project. Since we technically also generate components, we should respect the default option value for those options if _not_ explicitly specified. Closes angular#11874.
devversion
force-pushed
the
feat/ng-add-respect-inall-project-default-options
branch
from
643a296 to
aa770c4
Compare
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
If developers create a new Angular CLI project, options like
--skipTests,--inlineTemplateor--inlineStylecan be specified. These options will be stored in the workspace config file and will be respected if someone generates another component on the existing project.Since we technically also generate components, we should respect the default option value for those options if not explicitly specified.
Closes #11874.