Skip to content

fix(drag-drop): dragging class not being applied on drop container #12921

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 11, 2018

Conversation

crisbeto
Copy link
Member

Fixes the cdk-drop-dragging class not being applied to the drop container after 5d0ec23. The introduction of the onStable call caused the event to be bound outside the NgZone.

Fixes the `cdk-drop-dragging` class not being applied to the drop container after 5d0ec23. The introduction of the `onStable` call caused the event to be bound outside the `NgZone`.
@crisbeto crisbeto added the target: major This PR is targeted for the next major release label Aug 31, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner August 31, 2018 06:42
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 31, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 31, 2018
@crisbeto crisbeto added the P2 The issue is important to a large percentage of users, with a workaround label Sep 10, 2018
@crisbeto
Copy link
Member Author

Bumping this to a P2, because it affects more than just the class not being applied.

@jelbourn jelbourn merged commit ec0de52 into angular:master Sep 11, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants