-
Notifications
You must be signed in to change notification settings - Fork 6.8k
fix(sort): indicator hint not showing up on mobile #12942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sort): indicator hint not showing up on mobile #12942
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
730095e
to
54c38f8
Compare
@devversion Can you rebase when you have a chance? |
* Due to the fact that the sort module uses the `(longpress)` event, the custom HammerJS gesture config needs to be provided. Related to angular#12940
54c38f8
to
c66d608
Compare
@josephperrott Done! thanks for the ping. |
~40 targets failing in google3 with an error like: |
@mmalerba Thanks for trying to sync it. I can't think why this would happen as there is nothing special with providing the gesture config (we do this for other components as well). Can we figure out where this error is thrown? |
Looks like an issue when compiling the components in some tests. Here's the stack trace (edited to remove any google3-specific details):
|
Closing this now as we will be removing HammerJS anyway in v9. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
(longpress)
event, the custom HammerJS gesture config needs to be provided.Related to #12940