Skip to content

fix(sort): indicator hint not showing up on mobile #12942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

devversion
Copy link
Member

@devversion devversion commented Sep 1, 2018

  • Due to the fact that the sort module uses the (longpress) event, the custom HammerJS gesture config needs to be provided.

Related to #12940

@devversion devversion added the target: patch This PR is targeted for the next patch release label Sep 1, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 1, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 4, 2018
@devversion devversion force-pushed the fix/sort-indicator-hint-showing-up-longpress branch 2 times, most recently from 730095e to 54c38f8 Compare November 10, 2018 08:53
@mmalerba mmalerba added aaa and removed aaa labels Apr 25, 2019
@andrewseguin andrewseguin added the P2 The issue is important to a large percentage of users, with a workaround label May 30, 2019
@josephperrott
Copy link
Member

@devversion Can you rebase when you have a chance?

* Due to the fact that the sort module uses the `(longpress)` event, the custom HammerJS gesture config needs to be provided.

Related to angular#12940
@devversion devversion force-pushed the fix/sort-indicator-hint-showing-up-longpress branch from 54c38f8 to c66d608 Compare June 7, 2019 18:12
@devversion
Copy link
Member Author

@josephperrott Done! thanks for the ping.

@mmalerba
Copy link
Contributor

~40 targets failing in google3 with an error like: TypeError: Cannot read property 'type' of undefined

@mmalerba mmalerba added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Aug 13, 2019
@devversion
Copy link
Member Author

@mmalerba Thanks for trying to sync it. I can't think why this would happen as there is nothing special with providing the gesture config (we do this for other components as well). Can we figure out where this error is thrown?

@mmalerba
Copy link
Contributor

Looks like an issue when compiling the components in some tests. Here's the stack trace (edited to remove any google3-specific details):

TypeError: Cannot read property 'type' of undefined
    at JitCompiler._addAotSummaries compiler/src/jit/compiler.ts?l=95
    at JitCompiler._addAotSummaries compiler/src/jit/compiler.ts?l=91
    at JitCompiler._addAotSummaries compiler/src/jit/compiler.ts?l=91
    at JitCompiler.loadAotSummaries compiler/src/jit/compiler.ts?l=79
    at CompilerImpl.loadAotSummaries platform-browser-dynamic/src/compiler_factory.ts?l=75
    at TestingCompilerImpl.loadAotSummaries platform-browser-dynamic/testing/src/compiler_factory.ts?l=97
    at TestBedViewEngine._createCompilerAndModule core/testing/src/test_bed.ts?l=438
    at TestBedViewEngine.compileComponents core/testing/src/test_bed.ts?l=361
    at Function.TestBedViewEngine.compileComponents core/testing/src/test_bed.ts?l=160
    at compileComponents ...
    at step (tslib/tslib_closure.js?l=199)
    at Object.next (tslib/tslib_closure.js?l=147)
    at tslib/tslib_closure.js:119:65

@devversion
Copy link
Member Author

Closing this now as we will be removing HammerJS anyway in v9.

@devversion devversion closed this Aug 28, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants