refactor(schematics): avoid typescript version conflicts #12989
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
target: major
devversion
force-pushed
the
refactor/schematics-typescript-version-conflicts
branch
2 times, most recently
from
a00e56b to
99db7ed
Compare
devversion
force-pushed
the
refactor/schematics-typescript-version-conflicts
branch
from
7d07856 to
99db7ed
Compare
The Angular Material schematics parse TypeScript sources files and pass the AST to the `@schematics/angular` package which defined an explicit dependency on `typescript`. Since we currently just always require the flattened `typescript` dependency (`node_modules/typescript`), there could be either no TypeScript version or a different TypeScript version that causes the AST operations of the `@schematics/angular` utility functions to not work properly (e.g. different `SyntaxKind` ids) We should primarily try to load the same TypeScript version that has been shipped with the `@schematics/angular`. If that one couldn't be found, fall back to the top level `typescript` version.
devversion
force-pushed
the
refactor/schematics-typescript-version-conflicts
branch
from
98b7df8 to
33cb34c
Compare
devversion
deleted the
refactor/schematics-typescript-version-conflicts
branch
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Angular Material schematics parse TypeScript sources files and pass the AST to the
@schematics/angularpackage which defined an explicit dependency ontypescript. Since we currently just always require the flattenedtypescriptdependency (node_modules/typescript), there could be either no TypeScript version or a different TypeScript version that causes the AST operations of the@schematics/angularutility functions to not work properly (e.g. differentSyntaxKindids)We should primarily try to load the same TypeScript version that has been shipped with the
@schematics/angular. If that one couldn't be found, fall back to the top leveltypescriptversion.