chore: use computed radius size for checkbox ripple during 2018 material spec update transition #13038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephperrott
added
the
target: major
googlebot
added
the
cla: yes
|
Isn't the ripple just supposed to be ~40px. I've addressed it in #12493. |
josephperrott
force-pushed
the
checkbox-ripple
branch
2 times, most recently
from
74d963d to
be4c912
Compare
devversion
approved these changes
Sep 7, 2018
devversion
reviewed
Sep 7, 2018
src/lib/checkbox/checkbox.ts
Outdated
| setTimeout(() => { | ||
| if (!calculatedRippleRadius) { | ||
| const rippleWidth = parseInt(getComputedStyle( | ||
| this._elementRef.nativeElement.querySelector('.mat-checkbox-ripple')).width!, 10) || 0; |
There was a problem hiding this comment.
We could probably also use clientWidth instead, but either way works.
josephperrott
force-pushed
the
checkbox-ripple
branch
from
be4c912 to
2ac6e14
Compare
This comment has been minimized.
This comment has been minimized.
devversion
reviewed
Sep 8, 2018
| @@ -210,6 +215,10 @@ export class MatCheckbox extends _MatCheckboxMixinBase implements ControlValueAc | |||
| .subscribe(focusOrigin => this._onInputFocusChange(focusOrigin)); | |||
| } | |||
|
|
|||
| ngAfterViewChecked() { | |||
There was a problem hiding this comment.
There is actually one lint error because AfterViewChecked interface isn't applied. Feel free to add merge ready when done.
…ial spec update transition
josephperrott
force-pushed
the
checkbox-ripple
branch
from
2ac6e14 to
e58e468
Compare
devversion
approved these changes
Sep 10, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.