Skip to content

refactor(schematics): add test case for overlay property name change #13140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

  • Moves the breaking change for flexibleDimension into the V7 target data. This is currently in V6 because at the time of the PR, this data distinction didn't exist.
  • Adds a test-case for that breaking change

* Moves the breaking change for `flexibleDimension` into the V7 target data. This is currently in V6 because at the time of the PR, this data distinction didn't exist.
* Adds a test-case for that breaking change
@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Sep 15, 2018
@devversion devversion requested a review from amcdnl as a code owner September 15, 2018 16:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 15, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Sep 16, 2018
@jelbourn jelbourn merged commit f10fdfc into angular:master Sep 16, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants