Skip to content

fix(select): use pointer cursor for native select when not disabled #13184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2018
Merged

fix(select): use pointer cursor for native select when not disabled #13184

merged 1 commit into from
Oct 3, 2018

Conversation

vivian-hu-zz
Copy link
Contributor

No description provided.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 18, 2018
crisbeto
crisbeto reviewed Sep 18, 2018
View reviewed changes
@vivian-hu-zz vivian-hu-zz force-pushed the selectMouse branch 2 times, most recently from 499e753 to 588210e Compare September 18, 2018 20:26
crisbeto
crisbeto approved these changes Sep 18, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Sep 18, 2018
@ngbot
Copy link

ngbot bot commented Sep 27, 2018

Hi @vivian-hu! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

2 similar comments
@ngbot
Copy link

ngbot bot commented Sep 27, 2018

Hi @vivian-hu! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@ngbot
Copy link

ngbot bot commented Sep 27, 2018

Hi @vivian-hu! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@jelbourn
Copy link
Member

@vivian-hu just needs a rebase, passes presubmit

@vivian-hu-zz vivian-hu-zz merged commit c07184d into angular:master Oct 3, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@vivian-hu-zz @roboshoes
use pointer cursor for native select when not disabled (angular#13184)
9a5cf7a
@vivian-hu-zz vivian-hu-zz deleted the selectMouse branch January 23, 2019 23:01
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vivian-hu-zz @jelbourn @crisbeto @googlebot