fix(form-field): native select options blending in with dropdown background on a dark theme #13201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ground on a dark theme When we have a dark theme, we set the color of `select` to white which ends up propagating to the `option` elements, causing them to blend in with the background which is always white. These changes set the options explicitly to a dark color for dark themes.
crisbeto
added
P2
googlebot
added
the
cla: yes
|
Marking as P2 since the issue makes |
mmalerba
approved these changes
Oct 18, 2018
mmalerba
added
pr: lgtm
action: merge
josephperrott
pushed a commit
that referenced
this pull request
Oct 19, 2018
…ground on a dark theme (#13201)
josephperrott
pushed a commit
that referenced
this pull request
Oct 19, 2018
…ground on a dark theme (#13201)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we have a dark theme, we set the color of
selectto white which ends up propagating to theoptionelements, causing them to blend in with the background which is always white. These changes set the options explicitly to a dark color for dark themes.For reference:
