fix(slide-toggle): no focus indication in high-contrast mode #13287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
devversion
commented
Sep 24, 2018
devversion
commented
- Fixes that the slide-toggle does not have any visible focus indication in high contrast mode.
devversion
added
Accessibility
googlebot
added
the
cla: yes
crisbeto
reviewed
Sep 24, 2018
| // because otherwise the opaque thumb element will hide the outline. | ||
| .mat-slide-toggle.cdk-keyboard-focused & { | ||
| outline: 1px dotted; | ||
| outline-offset: ($mat-slide-toggle-height - $mat-slide-toggle-bar-height) / 2; |
There was a problem hiding this comment.
Based on MDN, outline-offset isn't supported on IE. Can we add it on another element?
crisbeto
approved these changes
Sep 24, 2018
crisbeto
added
pr: lgtm
action: merge
devversion
added
target: patch
devversion
force-pushed
the
fix/slide-toggle-high-contrast
branch
from
d279662 to
a17caa2
Compare
|
Hi @devversion! This PR has merge conflicts due to recent upstream merges. |
devversion
force-pushed
the
fix/slide-toggle-high-contrast
branch
from
a17caa2 to
30dd524
Compare
* Fixes that the slide-toggle does not have any visible focus indication in high contrast mode.
devversion
force-pushed
the
fix/slide-toggle-high-contrast
branch
from
30dd524 to
ce14c07
Compare
josephperrott
pushed a commit
that referenced
this pull request
Nov 19, 2018
* Fixes that the slide-toggle does not have any visible focus indication in high contrast mode.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.