refactor: add support for noImplicitAny #13381
Conversation
crisbeto
requested review from
amcdnl,
andrewseguin,
devversion,
jelbourn,
josephperrott and
mmalerba
as code owners
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
13330/no-implicit-any
branch
3 times, most recently
from
9092bd8 to
0b5bc38
Compare
| @Inject(DIALOG_REF) private dialogRefConstructor, | ||
| @Inject(DIALOG_SCROLL_STRATEGY) private _scrollStrategy, | ||
| @Inject(DIALOG_REF) private dialogRefConstructor: Type<DialogRef<any>>, | ||
| @Inject(DIALOG_SCROLL_STRATEGY) scrollStrategy: any, |
There was a problem hiding this comment.
Why can't this be ScrollStrategy?
(same for other places that inject a strategy)
There was a problem hiding this comment.
It's actually a () => ScrollStrategy. It can't have the actual type in here, because the compiler complains about it. I tried introducing a new type called ScrollStrategyFactory, but that ended up breaking in a different way.
There was a problem hiding this comment.
Could you add a TODO to change it back once we're using the ivy renderer? It will fix the problem that prevents the correct type from being used.
crisbeto
force-pushed
the
13330/no-implicit-any
branch
2 times, most recently
from
b4ab821 to
5251a42
Compare
jelbourn
changed the title
jelbourn
added
the
merge: fix commit message
Enables the `noImplicitAny` compiler option and fixes all of the resulting compiler errors. Fixes angular#13330.
crisbeto
force-pushed
the
13330/no-implicit-any
branch
from
5251a42 to
eb3dc7e
Compare
Enables the `noImplicitAny` compiler option and fixes all of the resulting compiler errors. Fixes angular#13330.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Enables the
noImplicitAnycompiler option and fixes all of the resulting compiler errors.Fixes #13330.