docs: clean up and clarify theming docs #13435
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelbourn
added
docs
googlebot
added
the
cla: yes
josephperrott
approved these changes
Oct 5, 2018
guides/theming-your-components.md
Outdated
| @@ -1,80 +1,81 @@ | |||
| # Theming your custom components | |||
| In order to style your own components with Angular Material's tooling, the component's styles must be defined with Sass. | |||
| ### Theming your own component the Angular Material way | |||
There was a problem hiding this comment.
Should this be something like
Theming your component using Angular Material's theming system
guides/theming-your-components.md
Outdated
| We can better theme our custom components by adding a `@mixin` function to its theme file, and then call this function to apply a theme. | ||
|
|
||
| All you need is to create a `@mixin` function in the custom-component-theme.scss | ||
| #### 1. Define all color and typography styles in a "theme mixin" for the component |
There was a problem hiding this comment.
This section should include examples for both theme and typography, currently we mention typography but don't show it in the examples.
This makes some minor wording changes to the main theming guide and mostly rewrites the theming-your-own-component guide. Edited for clarify, brevity, and language. Fixes angular#13206
jelbourn
force-pushed
the
theming-docs-tweaks
branch
from
49ba6a3 to
0d37cf8
Compare
roboshoes
pushed a commit
to roboshoes/material2
that referenced
this pull request
Oct 23, 2018
This makes some minor wording changes to the main theming guide and mostly rewrites the theming-your-own-component guide. Edited for clarify, brevity, and language. Fixes angular#13206
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes some minor wording changes to the main theming guide and mostly rewrites the theming-your-own-component guide. Edited for clarify, brevity, and language.
Fixes #13206