Skip to content

chore(docs): hide value accessors from docs #13453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 5, 2018
Merged

chore(docs): hide value accessors from docs #13453

merged 1 commit into from
Oct 5, 2018

Conversation

devversion
Copy link
Member

  • Since we recently added logic for showing constants in the docs, we should avoid showing the value accessor constants which are actually just used kind-of internally.

@devversion
chore(docs): hide value accessors from docs
74e1de3 
* Since we recently added logic for showing constants in the docs, we should avoid showing the value accessor constants which are actually just used kind-of internally.
@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Oct 5, 2018
@devversion devversion requested a review from mmalerba as a code owner October 5, 2018 19:40
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2018
@devversion devversion added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Oct 5, 2018
jelbourn
jelbourn approved these changes Oct 5, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 5, 2018
@vivian-hu-zz vivian-hu-zz merged commit b7de6be into angular:master Oct 5, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@devversion @roboshoes
chore(docs): hide value accessors from docs (angular#13453)
b809329 
* Since we recently added logic for showing constants in the docs, we should avoid showing the value accessor constants which are actually just used kind-of internally.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @googlebot @vivian-hu-zz