Skip to content

fix(button-toggle): content shifting in IE11 #13492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2018
Merged

fix(button-toggle): content shifting in IE11 #13492

merged 1 commit into from
Oct 19, 2018

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 8, 2018

Prevents IE from shifting the button toggle's content when clicked.

For reference:
demo2

@crisbeto
fix(button-toggle): content shifting in IE11
37f30d8 
Prevents IE from shifting the button toggle's content when clicked.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 8, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner October 8, 2018 15:11
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 8, 2018
jelbourn
jelbourn approved these changes Oct 8, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 8, 2018
@josephperrott josephperrott merged commit b3483a6 into angular:master Oct 19, 2018
josephperrott pushed a commit that referenced this pull request Oct 19, 2018
@crisbeto @josephperrott
fix(button-toggle): content shifting in IE11 (#13492)
d73fe17
josephperrott pushed a commit that referenced this pull request Oct 19, 2018
@crisbeto @josephperrott
fix(button-toggle): content shifting in IE11 (#13492)
7f5cbe3
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @josephperrott