demo(prerender): add theme to prerender demo #13516
Conversation
mmalerba
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
| @@ -0,0 +1,16 @@ | |||
| @import '../lib/core/theming/all-theme'; | |||
There was a problem hiding this comment.
Couldn't we reuse one of the prebuilt themes here? That's what we do for the unit tests: https://github.com/angular/material2/blob/master/test/karma.conf.js#L39
There was a problem hiding this comment.
I could if you feel strongly that we should do that. I did it this way because I plan to work on some prototypes with MDC that would add optional flags to the theme mixins.
There was a problem hiding this comment.
I don't feel strongly about it, I wasn't aware that we needed it for more than just a theme.
| @@ -0,0 +1,16 @@ | |||
| @import '../lib/core/theming/all-theme'; | |||
There was a problem hiding this comment.
I don't feel strongly about it, I wasn't aware that we needed it for more than just a theme.
mmalerba
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No description provided.