Skip to content

refactor(schematics): add test cases for cdk ng-update #13517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2018
Merged

refactor(schematics): add test cases for cdk ng-update #13517

merged 1 commit into from
Oct 15, 2018

Conversation

devversion
Copy link
Member

@devversion devversion commented Oct 9, 2018 •
edited
Loading

  • Adds test cases that had to be removed in favor for a quick implementation of CDK ng update. Now both CDK and Material update schematics should be covered.

@devversion devversion requested a review from jelbourn as a code owner October 9, 2018 18:10
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 9, 2018
@devversion devversion force-pushed the refactor/cdk-test-cases-ng-updaze branch 2 times, most recently from 9abd3eb to e63ea4f Compare October 9, 2018 18:16
@devversion devversion added pr: merge safe target: major This PR is targeted for the next major release labels Oct 9, 2018
@devversion devversion force-pushed the refactor/cdk-test-cases-ng-updaze branch 2 times, most recently from dadaa82 to ad9572f Compare October 9, 2018 18:25
jelbourn
jelbourn approved these changes Oct 10, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

Just needs rebase

@devversion devversion force-pushed the refactor/cdk-test-cases-ng-updaze branch from ad9572f to 65d013d Compare October 10, 2018 20:36
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Oct 10, 2018
@devversion
Copy link
Member Author

@jelbourn Done.

@andrewseguin andrewseguin added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Oct 11, 2018
@andrewseguin
Copy link
Contributor

Sorry, needs another rebase

@ngbot
Copy link

ngbot bot commented Oct 11, 2018

Hi @devversion! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@devversion devversion force-pushed the refactor/cdk-test-cases-ng-updaze branch from 65d013d to f3efc88 Compare October 11, 2018 18:34
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Oct 11, 2018
@devversion
Copy link
Member Author

Done @andrewseguin

@andrewseguin andrewseguin merged commit 6afe3f5 into angular:master Oct 15, 2018
roboshoes pushed a commit to roboshoes/material2 that referenced this pull request Oct 23, 2018
@devversion @roboshoes
refactor(schematics): add test cases for cdk ng-update (angular#13517)
02605e1
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @jelbourn @andrewseguin @googlebot