fix(radio): only show focus ripple for keyboard focus #13565
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
added
pr: lgtm
action: merge
jelbourn
added
blocked
crisbeto
added
target: patch
crisbeto
force-pushed
the
13544/radio-focus-ripple
branch
from
929e46e to
95b5444
Compare
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
1 similar comment
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
crisbeto
force-pushed
the
13544/radio-focus-ripple
branch
2 times, most recently
from
9e53c63 to
9865fb6
Compare
After the switch to the latest Material Design spec, we started showing the focus ripple for all kinds of focus, however it's only supposed to be for keyboard focus. Fixes angular#13544.
crisbeto
force-pushed
the
13544/radio-focus-ripple
branch
from
9865fb6 to
cfa2649
Compare
josephperrott
pushed a commit
that referenced
this pull request
Mar 5, 2019
After the switch to the latest Material Design spec, we started showing the focus ripple for all kinds of focus, however it's only supposed to be for keyboard focus. Fixes #13544.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the switch to the latest Material Design spec, we started showing the focus ripple for all kinds of focus, however it's only supposed to be for keyboard focus.
Fixes #13544.