fix(progress-bar): not taking current path after first initialization #13628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we use a provider in the progress bar in order to get the current path and to account for server-side rendering. Since the provider is an object with a plain `pathname` property, Angular will create it once and cache it, which means that we'll always get the first path that it landed on. The issue can be seen by going to the card demos and then clicking through to the progress bar demo.
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 17, 2018
When resolving the current path while prefixing `url()` references, we use a provider to get the current path so we can account for server-side rendering and to be able to stub it out during tests. Since the provider is an object with a regular `pathname` property, the path will only be resolved once the first time an icon is resolved and then it'll be cached. This means that all subsequent icons will take an incorrect path. Related to angular#13628.
josephperrott
pushed a commit
that referenced
this pull request
Oct 18, 2018
When resolving the current path while prefixing `url()` references, we use a provider to get the current path so we can account for server-side rendering and to be able to stub it out during tests. Since the provider is an object with a regular `pathname` property, the path will only be resolved once the first time an icon is resolved and then it'll be cached. This means that all subsequent icons will take an incorrect path. Related to #13628.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Oct 18, 2018
When resolving the current path while prefixing `url()` references, we use a provider to get the current path so we can account for server-side rendering and to be able to stub it out during tests. Since the provider is an object with a regular `pathname` property, the path will only be resolved once the first time an icon is resolved and then it'll be cached. This means that all subsequent icons will take an incorrect path. Related to angular#13628.
josephperrott
pushed a commit
that referenced
this pull request
Oct 18, 2018
When resolving the current path while prefixing `url()` references, we use a provider to get the current path so we can account for server-side rendering and to be able to stub it out during tests. Since the provider is an object with a regular `pathname` property, the path will only be resolved once the first time an icon is resolved and then it'll be cached. This means that all subsequent icons will take an incorrect path. Related to #13628.
josephperrott
pushed a commit
that referenced
this pull request
Oct 19, 2018
josephperrott
pushed a commit
that referenced
this pull request
Oct 19, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we use a provider in the progress bar in order to get the current path and to account for server-side rendering. Since the provider is an object with a plain
pathnameproperty, Angular will create it once and cache it, which means that we'll always get the first path that it landed on. The issue can be seen by going to the card demos and then clicking through to the progress bar demo.