Skip to content

feat(drag-drop): add the ability to disable dragging #13722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 14, 2018

Conversation

crisbeto
Copy link
Member

Adds inputs to cdkDrag, cdkDropList and cdkDragHandle that allows for dragging to be disabled through those specific elements.

Fixes #13651.

@crisbeto crisbeto added the target: minor This PR is targeted for the next minor release label Oct 21, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner October 21, 2018 10:37
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 21, 2018
@philmtd
Copy link

philmtd commented Oct 24, 2018

Just curious: Why is it, that this feature is targeted for the next minor release while other new features are targeted for the next patch? Is this more complex in some way?

@crisbeto
Copy link
Member Author

We have a rule that it’s mostly bug fixes that go into patch releases, whereas features go into minor.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2018
@100cm
Copy link

100cm commented Nov 1, 2018

hey, when will this pr be merged..

@jelbourn
Copy link
Member

jelbourn commented Nov 3, 2018

@crisbeto passes presubmit, just needs rebase

@ngbot
Copy link

ngbot bot commented Nov 3, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@crisbeto crisbeto force-pushed the 13651/drag-disabled branch from 858af25 to d5a885b Compare November 4, 2018 17:28
@crisbeto
Copy link
Member Author

crisbeto commented Nov 4, 2018

Rebased.

Adds inputs to `cdkDrag`, `cdkDropList` and `cdkDragHandle` that allows for dragging to be disabled through those specific elements.

Fixes angular#13651.
@100cm
Copy link

100cm commented Nov 12, 2018

any update?

@andrewseguin andrewseguin merged commit b02a72e into angular:master Nov 14, 2018
josephperrott pushed a commit that referenced this pull request Nov 19, 2018
Adds inputs to `cdkDrag`, `cdkDropList` and `cdkDragHandle` that allows for dragging to be disabled through those specific elements.

Fixes #13651.
@ghost
Copy link

ghost commented Nov 27, 2018

Drag can be disabled using cdkDragDisabled property. How do i disable drop ? I wish there were a cdkDropDisabled property too. Though cdkDragDisabled is introduced in 7.1.0. expecting more option soon.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drag-drop: Provide option to enable/disable dragging of elements
6 participants