build: run browserstack on circleci #13749
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked for now because due to the GitHub issues, CircleCI is not able to run jobs for this PR. |
devversion
added
blocked
.circleci/config.yml
Outdated
| @@ -189,6 +208,7 @@ workflows: | |||
| unit_tests: | |||
| jobs: | |||
| - tests_local_browsers | |||
| - browserstack_tests | |||
There was a problem hiding this comment.
Can we do tests_browserstack. So the naming convention is consistent
There was a problem hiding this comment.
Good point. Will update that
This comment has been minimized.
This comment has been minimized.
googlebot
removed
the
cla: yes
josephperrott
added
the
cla: yes
|
CLA confirmed manually |
devversion
force-pushed
the
build/run-browserstack-circle
branch
5 times, most recently
from
4d15d1d to
7ac57b0
Compare
devversion
force-pushed
the
build/run-browserstack-circle
branch
from
e35a2d7 to
0b9c94c
Compare
devversion
removed
blocked
jelbourn
added
pr: lgtm
action: merge
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.