Skip to content

fix(checkbox): disabled property not being coerced #13755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2018

Conversation

crisbeto
Copy link
Member

Fixes the disabled property not being coerced like all the other components.

Fixes #13739.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 22, 2018
@crisbeto crisbeto force-pushed the 13739/checkbox-disabled-coercion branch from 67baa7d to 6391317 Compare October 22, 2018 20:23
Fixes the `disabled` property not being coerced like all the other components.

Fixes angular#13739.
@crisbeto crisbeto force-pushed the 13739/checkbox-disabled-coercion branch from 6391317 to 4bdbf44 Compare October 22, 2018 20:23
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 22, 2018
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 23, 2018
@mmalerba mmalerba merged commit e5fe34c into angular:master Oct 23, 2018
mmalerba pushed a commit that referenced this pull request Oct 26, 2018
Fixes the `disabled` property not being coerced like all the other components.

Fixes #13739.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

disabled input on mat-checkbox not behaving like with other components
6 participants