Skip to content

docs(drag-drop): add doc section and live example for customizing the placeholder #13777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2018
Merged

docs(drag-drop): add doc section and live example for customizing the placeholder #13777

merged 1 commit into from
Oct 24, 2018

Conversation

crisbeto
Copy link
Member

Adds a paragraph about the cdkDragPlaceholder and sets up a live example.

Fixes #13765.

@crisbeto
docs(drag-drop): add doc section and live example for customizing the…
a274b18 
… placeholder

Adds a paragraph about the `cdkDragPlaceholder` and sets up a live example.

Fixes angular#13765.
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 23, 2018
@crisbeto crisbeto requested a review from jelbourn as a code owner October 23, 2018 20:51
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 23, 2018
@jimitndiaye
Copy link
Contributor

jimitndiaye commented Oct 24, 2018 •
edited
Loading

@crisbeto Might I suggest expanding the example to be similar to the ToDo connected sorting example with two lists (one of which is not a cdkDropList)? The reason I bring that up is that because the cdkDragPlaceholder is defined on the ckdDrag rather than the cdkDropList you'd need to have a second cdkDragPlaceholder on the drag items of the second list even though the placeholder will be shown in the first list. This is not obvious behavior (at least to me) and probably needs to be emphasized.

jelbourn
jelbourn approved these changes Oct 24, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 24, 2018
@mmalerba mmalerba merged commit 530c0eb into angular:master Oct 24, 2018
mmalerba pushed a commit that referenced this pull request Oct 26, 2018
@crisbeto @mmalerba
docs(drag-drop): add doc section and live example for customizing the…
77451d4 
… placeholder (#13777)

Adds a paragraph about the `cdkDragPlaceholder` and sets up a live example.

Fixes #13765.
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@crisbeto @atscott
docs(drag-drop): add doc section and live example for customizing the…
7899dc5 
… placeholder (angular#13777)

Adds a paragraph about the `cdkDragPlaceholder` and sets up a live example.

Fixes angular#13765.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for drop target placeholder to CDK drag and drop
5 participants
@crisbeto @jimitndiaye @jelbourn @googlebot @mmalerba