Skip to content

fix(drag-drop): multiple parallel drag sequences when dragging nested drag items #13820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 3, 2018

Conversation

crisbeto
Copy link
Member

Currently if we have a cdkDrag nested inside another cdkDrag, the user can start dragging both of the items at the same time if they starting dragging from the appropriate area. These change stop event propagation so only one drag sequence can be started from a certain area at a time.

… drag items

Currently if we have a `cdkDrag` nested inside another `cdkDrag`, the user can start dragging both of the items at the same time if they starting dragging from the appropriate area. These change stop event propagation so only one drag sequence can be started from a certain area at a time.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Oct 25, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 25, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ked1
Copy link

ked1 commented Oct 31, 2018

The pull request seems to be ready for merge... til when we can expect it to be completed?
I expect my current issue will be fixed with it - thanks for this great tools!

@jelbourn jelbourn merged commit 436809c into angular:master Nov 3, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
… drag items (angular#13820)

Currently if we have a `cdkDrag` nested inside another `cdkDrag`, the user can start dragging both of the items at the same time if they starting dragging from the appropriate area. These change stop event propagation so only one drag sequence can be started from a certain area at a time.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
… drag items (#13820)

Currently if we have a `cdkDrag` nested inside another `cdkDrag`, the user can start dragging both of the items at the same time if they starting dragging from the appropriate area. These change stop event propagation so only one drag sequence can be started from a certain area at a time.
@nicbil
Copy link

nicbil commented Nov 11, 2018

@crisbeto @jelbourn Tell me please. How does nesting work? I try to move 1-container to 0-container. For test- https://stackblitz.com/edit/angular-lcmwes

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants