build: share release output between circle jobs #13838
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/circleci-workspace-sharing
branch
from
ef7bb68 to
be3e022
Compare
devversion
force-pushed
the
build/circleci-workspace-sharing
branch
from
be3e022 to
9696ff8
Compare
devversion
force-pushed
the
build/circleci-workspace-sharing
branch
from
c95e4ed to
766b23a
Compare
devversion
commented
Oct 27, 2018
| const chunkSize = Math.floor((browsers.length - assignedBrowsers) / (maxInstances - i)); | ||
| chunks[i] = browsers.slice(assignedBrowsers, assignedBrowsers + chunkSize); | ||
| assignedBrowsers += chunkSize; | ||
| } |
There was a problem hiding this comment.
@jelbourn You probably have some better ideas to split an array into a maximum size of chunks in a deterministic way.
Note that I intentionally didn't consider splitting the actual tests across browsers because we want to run all specs on all browsers specified for BrowserStack.
devversion
added
pr: merge safe
target: patch
jelbourn
approved these changes
Oct 29, 2018
jelbourn
added
pr: lgtm
action: merge
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
Also support parallel Karma instances on CircleCI
jelbourn
pushed a commit
that referenced
this pull request
Nov 6, 2018
Also support parallel Karma instances on CircleCI
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Runs a new job that builds the release output and persists it to the CircleCI workspace storage. This can be used to run the AOT tests, CLI integration tests (#13456), publish artifacts etc without rebuilding everything again.
Runs two parallel instances of Browserstack with the goal of replacing Saucelabs completely with Browserstack. Also a benefit is that we can now use packages like
karma-parallelto speed up tests per instance without the downside of just running specific tests on a specific browser.