build: do not run browserstack in parallel #13861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
@jelbourn I'm also up to removing the array split logic because technically it's doing nothing then. |
devversion
added
pr: merge safe
target: patch
* No longer runs BrowserStack in parallel because it causes rate limit exceptions that didn't show up if we just had one tunnel per job.
devversion
force-pushed
the
build/no-parallel-browserstack
branch
from
277cf4e to
551fac8
Compare
jelbourn
added
pr: lgtm
action: merge
atscott
pushed a commit
to atscott/components
that referenced
this pull request
Nov 5, 2018
* No longer runs BrowserStack in parallel because it causes rate limit exceptions that didn't show up if we just had one tunnel per job.
jelbourn
pushed a commit
that referenced
this pull request
Nov 6, 2018
* No longer runs BrowserStack in parallel because it causes rate limit exceptions that didn't show up if we just had one tunnel per job.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I've kept the array split logic because it's made to respect the
parallelismoption from Circle, so it should be fine to keep this function in our code base. It might be useful if we revisit with a new BS license or if we want to run multiple instances of the local browsers etc.