Skip to content

build: move snapshot publish job to circleci #13882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 1, 2018
Merged

build: move snapshot publish job to circleci #13882

merged 2 commits into from
Nov 1, 2018

Conversation

devversion
Copy link
Member

Needs the following tokens to be available within CircleCI:

  • MATERIAL2_BUILDS_TOKEN
  • MATERIAL2_DOCS_CONTENT_TOKEN

I'd vote for combining this tokens into a single one at some point.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Oct 30, 2018
@devversion devversion requested a review from jelbourn as a code owner October 30, 2018 18:07
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 30, 2018
@devversion devversion force-pushed the build/move-snapshot-publish-circleci branch 2 times, most recently from b091bf3 to a26c782 Compare October 30, 2018 18:23
jelbourn
jelbourn approved these changes Oct 30, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'll see if I can add the environment variables tonight

@jelbourn jelbourn added pr: lgtm blocked This issue is blocked by some external factor, such as a prerequisite PR labels Oct 30, 2018
@jelbourn
Copy link
Member

Blocked on me adding environment variables to CircleCI

@devversion devversion force-pushed the build/move-snapshot-publish-circleci branch from a26c782 to f7c1d17 Compare November 1, 2018 18:17
@devversion
Copy link
Member Author

@jelbourn I've switched the docs-content deloyment task to the single token we discussed.

@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed blocked This issue is blocked by some external factor, such as a prerequisite PR labels Nov 1, 2018
@jelbourn jelbourn merged commit 62f35dd into angular:master Nov 1, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
@devversion @atscott
build: move snapshot publish job to circleci (angular#13882)
cacffbd 
Also switch to a single GitHub deploy token
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
@devversion @jelbourn
build: move snapshot publish job to circleci (#13882)
1a9472e 
Also switch to a single GitHub deploy token
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot