-
Notifications
You must be signed in to change notification settings - Fork 6.8k
docs: pointing out breaking change for MatSidenav and MatDrawer in 7.0 #13902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Added description to Breaking changes that the template for MatSidenav and MatDrawer have changed. Was done in this angular@0f83c18 commit.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I don't agree that this is a breaking change. Most of the time, we don't consider the structure of the component to constitute a formal public API. I do think it would be good to add a note to the changelog, but not in the "breaking changes" section. Additionally, the note should be more specific about what the change consists of rather than the broad statement that "the template has changed" |
It actually breaks the design of a page if you have a css selector like |
@Isitar sorry I merged this before realizing the |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Added description to Breaking changes that the template for MatSidenav and MatDrawer have changed. Was done in this 0f83c18 commit.