Skip to content

docs: pointing out breaking change for MatSidenav and MatDrawer in 7.0 #13902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 29, 2019

Conversation

Isitar
Copy link
Contributor

@Isitar Isitar commented Oct 31, 2018

Added description to Breaking changes that the template for MatSidenav and MatDrawer have changed. Was done in this 0f83c18 commit.

Added description to Breaking changes that the template for MatSidenav and MatDrawer have changed. Was done in this angular@0f83c18 commit.
@Isitar Isitar requested a review from jelbourn as a code owner October 31, 2018 10:45
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Oct 31, 2018
@Isitar
Copy link
Contributor Author

Isitar commented Oct 31, 2018

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Oct 31, 2018
@Isitar Isitar changed the title Updated Changelog docs: Updated Changelog Oct 31, 2018
@Isitar Isitar changed the title docs: Updated Changelog docs: pointing out breaking change for MatSidenav and MatDrawer in 7.0 Oct 31, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Oct 31, 2018
@jelbourn jelbourn removed pr: lgtm action: merge The PR is ready for merge by the caretaker labels Oct 31, 2018
@jelbourn
Copy link
Member

jelbourn commented Oct 31, 2018

I don't agree that this is a breaking change. Most of the time, we don't consider the structure of the component to constitute a formal public API. I do think it would be good to add a note to the changelog, but not in the "breaking changes" section. Additionally, the note should be more specific about what the change consists of rather than the broad statement that "the template has changed"

@Isitar
Copy link
Contributor Author

Isitar commented Oct 31, 2018

It actually breaks the design of a page if you have a css selector like mat-select > ul for example.
Wheter it is a breaking change or not is up to you, for me it is important that it is noted somewhere and I don't have to investigate in the components why my upgraded site looks different.

@mmalerba mmalerba merged commit 1b2e770 into angular:master Jan 29, 2019
mmalerba added a commit that referenced this pull request Jan 29, 2019
mmalerba added a commit that referenced this pull request Jan 29, 2019
@mmalerba
Copy link
Contributor

@Isitar sorry I merged this before realizing the pr: merge ready label had been removed and had to revert, please re-create this PR

mmalerba pushed a commit that referenced this pull request Feb 4, 2019
#13902)

* Updated Changelog

Added description to Breaking changes that the template for MatSidenav and MatDrawer have changed. Was done in this 0f83c18 commit.

* Update CHANGELOG.md
mmalerba added a commit that referenced this pull request Feb 4, 2019
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants