Skip to content

Removing ~ from @import command #13926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Conversation

afleischer
Copy link
Contributor

Under the current build of Angular CLI ( with Angular Material v.7.0.2), adding the ~ in the @import command will cause a compilation error. I am proposing to remove the tilde on line 38 to reflect this change for this version.

Under the current build of Angular CLI ( with Angular Material v.7.0.2), adding the ~ in the @import command will cause a compilation error.  I am proposing to remove the tilde on line 38 to reflect this change for this version.
@afleischer afleischer requested a review from jelbourn as a code owner November 1, 2018 16:52
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla label Nov 1, 2018
@afleischer
Copy link
Contributor Author

afleischer commented Nov 1, 2018 via email

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Nov 1, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 2, 2018
@jelbourn jelbourn merged commit 44f616a into angular:master Nov 2, 2018
atscott pushed a commit to atscott/components that referenced this pull request Nov 5, 2018
Under the current build of Angular CLI ( with Angular Material v.7.0.2), adding the `~` in the @import command is unnecessary.
jelbourn pushed a commit that referenced this pull request Nov 6, 2018
Under the current build of Angular CLI ( with Angular Material v.7.0.2), adding the `~` in the @import command is unnecessary.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants