Skip to content

feat(tabs): make the updatePagination method public #13935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2018
Merged

feat(tabs): make the updatePagination method public #13935

merged 1 commit into from
Nov 8, 2018

Conversation

josephperrott
Copy link
Member

Closes #13539

@josephperrott josephperrott added the target: minor This PR is targeted for the next minor release label Nov 1, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 1, 2018
crisbeto
crisbeto approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/lib/tabs/tab-header.ts
* Updating the view whether pagination should be enabled or not
* Updates the view whether pagination should be enabled or not.
*
* WARNING: Calling this method can be very costly in terms of performance. It should be called
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Double space after the full stop.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there are a few whitespaces which cause lint to fail.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces are hard

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Nov 1, 2018
@ngbot
Copy link

ngbot bot commented Nov 1, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "ci/circleci: lint" is failing
    pending status "ci/circleci: tests_browserstack" is pending
    pending status "ci/circleci: tests_local_browsers" is pending
    pending status "ci/circleci: e2e_tests" is pending
    pending status "ci/circleci: bazel_build_test" is pending
    pending status "ci/circleci: prerender_build" is pending
    pending status "ci/circleci: build_release_packages" is pending
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@devversion devversion removed the action: merge The PR is ready for merge by the caretaker label Nov 2, 2018
@josephperrott josephperrott added the action: merge The PR is ready for merge by the caretaker label Nov 2, 2018
@vivian-hu-zz vivian-hu-zz merged commit 1e4ee0c into angular:master Nov 8, 2018
@colinvella colinvella mentioned this pull request Nov 8, 2018
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
@josephperrott josephperrott deleted the update-pagination branch March 20, 2020 22:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion left review comments

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: minor This PR is targeted for the next minor release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tab component: pagination controls are not responsive to container width changes
5 participants
@josephperrott @crisbeto @devversion @googlebot @vivian-hu-zz