Skip to content

docs: remove internal build fixes from changelog #14224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 27, 2018
Merged

docs: remove internal build fixes from changelog #14224

merged 2 commits into from
Nov 27, 2018

Conversation

devversion
Copy link
Member

  • d0d97c3 has been accidentally marked as fix while it should be build.
  • a22a9fa has been re-added because we removed it manually from the changelog version (see deduping logic)
  • 985774a Same as for the commit above
  • 150c964 Is not a fix, and actually still internal because we miss documentation etc.

@devversion
docs: remove internal build fixes from changelog
34b9ac2 
* d0d97c3 has been accidentally marked as `fix` while it should be `build`.
* a22a9fa has been re-added because we removed it manually from the changelog version (see [deduping logic](https://github.com/angular/material2/blob/master/tools/gulp/tasks/changelog.ts#L90))
* 985774a Same as for the commit above
* 150c964 Is _not_ a fix, and actually still internal because we miss documentation etc.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Nov 20, 2018
@devversion devversion requested a review from jelbourn as a code owner November 20, 2018 22:43
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 20, 2018
@devversion devversion removed the target: patch This PR is targeted for the next patch release label Nov 20, 2018
@devversion devversion added target: major This PR is targeted for the next major release merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Nov 21, 2018
@devversion
Copy link
Member Author

devversion commented Nov 21, 2018 •
edited
Loading

Caretaker note: It's fine getting this one only into master I'd say. Otherwise we would need to update the 7.x and 7.1.x branches (which aren't commonly used to read changelog)

Edit: not sure which label I should apply if it's master only...

@devversion devversion removed the target: major This PR is targeted for the next major release label Nov 21, 2018
@josephperrott josephperrott added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla target: patch This PR is targeted for the next patch release pr: lgtm action: merge The PR is ready for merge by the caretaker and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Nov 27, 2018
@josephperrott
Copy link
Member

We can just use target: patch and the caretaker can decide about the actual cherry-picking since ideally we would include it in all of the branches changelog files.

@jelbourn jelbourn merged commit 6a6646b into master Nov 27, 2018
@jelbourn jelbourn deleted the cleanup-changelog-v7.1 branch November 27, 2018 21:03
jelbourn pushed a commit that referenced this pull request Dec 3, 2018
@devversion @jelbourn
docs: remove internal build fixes from changelog (#14224)
8354a63 
* docs: remove internal build fixes from changelog

* d0d97c3 has been accidentally marked as `fix` while it should be `build`.
* a22a9fa has been re-added because we removed it manually from the changelog version (see [deduping logic](https://github.com/angular/material2/blob/master/tools/gulp/tasks/changelog.ts#L90))
* 985774a Same as for the commit above
* 150c964 Is _not_ a fix, and actually still internal because we miss documentation etc.

* Remove unrelated whitespace change
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@devversion @josephperrott
docs: remove internal build fixes from changelog (angular#14224)
8923c04 
* docs: remove internal build fixes from changelog

* angular@d0d97c3 has been accidentally marked as `fix` while it should be `build`.
* angular@a22a9fa has been re-added because we removed it manually from the changelog version (see [deduping logic](https://github.com/angular/material2/blob/master/tools/gulp/tasks/changelog.ts#L90))
* angular@985774a Same as for the commit above
* angular@150c964 Is _not_ a fix, and actually still internal because we miss documentation etc.

* Remove unrelated whitespace change
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@josephperrott josephperrott

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@devversion @josephperrott @jelbourn @googlebot