build: pretty print example module #14264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* In order to debug the example data for the tests on `material.angular.io`, I had to look into the `example-module.ts` output, but it was nearly impossible to read because we don't pretty print the auto-generated code.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
commented
Nov 25, 2018
| .replace('${exampleComponents}', JSON.stringify(exampleComponents)) | ||
| .replace('${exampleList}', `[${exampleList}]`) | ||
| .replace('${exampleComponents}', JSON.stringify(exampleComponents, null, 2)) | ||
| .replace('${exampleList}', `[\n ${exampleList.join(',\n ')}\n]`) |
There was a problem hiding this comment.
FYI: we could also use JSON.stringify(X, null, 2), but we don't want the elements to be quoted and just joining the lines is faster.
jelbourn
added
pr: lgtm
action: merge
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
* In order to debug the example data for the tests on `material.angular.io`, I had to look into the `example-module.ts` output, but it was nearly impossible to read because we don't pretty print the auto-generated code.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
* In order to debug the example data for the tests on `material.angular.io`, I had to look into the `example-module.ts` output, but it was nearly impossible to read because we don't pretty print the auto-generated code.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
material.angular.io, I had to look into theexample-module.tsoutput, but it was nearly impossible to read because we don't pretty print the auto-generated code.