Skip to content

docs(tree): fix nested tree node example markup #14305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 29, 2018
Merged

docs(tree): fix nested tree node example markup #14305

merged 2 commits into from
Nov 29, 2018

Conversation

LayZeeDK
Copy link
Contributor

Correct typos in example markup for nested tree node.

Should this part

<ng-template cdkTreeNodeOutlet></ng-template>

be changed to

<ng-container cdkTreeNodeOutlet></ng-container>

as seen in Docs: Tree overview?

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 27, 2018
crisbeto
crisbeto approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Regarding the ng-template vs ng-container, AFAIK it doesn't really matter.

@crisbeto crisbeto added pr: lgtm docs This issue is related to documentation action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Nov 28, 2018
jymdman
jymdman reviewed Nov 28, 2018
View reviewed changes
@jelbourn jelbourn merged commit 287f134 into angular:master Nov 29, 2018
@LayZeeDK LayZeeDK deleted the bugfix/tree-docs-example branch November 29, 2018 21:56
jelbourn pushed a commit that referenced this pull request Dec 3, 2018
@LayZeeDK @jelbourn
docs(tree): fix nested tree node example markup (#14305)
b967130
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@LayZeeDK @josephperrott
docs(tree): fix nested tree node example markup (angular#14305)
aab3725
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jymdman jymdman jymdman left review comments

@crisbeto crisbeto crisbeto approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement docs This issue is related to documentation target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LayZeeDK @jymdman @crisbeto @jelbourn @googlebot