build: markdown-to-html rule should apply docs-specific transforms #14315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
force-pushed
the
build/markdown-html-bazel-docs-specific-transformations
branch
from
844efab to
66dc9bf
Compare
Currently when building the overview and guide files with Bazel, the following things are missing: * Replacing `<!-- example` comments with the corresponding HTML elements * Wrapping the HTML output with a `<div class="docs-markdown">` element * Rewriting relative links to the proper public guide URL. * Convert headings to "anchored" headings that can be referenced through URL fragments. All of these points are handled with this commit.
devversion
force-pushed
the
build/markdown-html-bazel-docs-specific-transformations
branch
from
66dc9bf to
551b6a7
Compare
|
Lint error |
|
Fixed @jelbourn |
jelbourn
pushed a commit
that referenced
this pull request
Dec 3, 2018
…14315) Currently when building the overview and guide files with Bazel, the following things are missing: * Replacing `<!-- example` comments with the corresponding HTML elements * Wrapping the HTML output with a `<div class="docs-markdown">` element * Rewriting relative links to the proper public guide URL. * Convert headings to "anchored" headings that can be referenced through URL fragments. All of these points are handled with this commit.
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
…ngular#14315) Currently when building the overview and guide files with Bazel, the following things are missing: * Replacing `<!-- example` comments with the corresponding HTML elements * Wrapping the HTML output with a `<div class="docs-markdown">` element * Rewriting relative links to the proper public guide URL. * Convert headings to "anchored" headings that can be referenced through URL fragments. All of these points are handled with this commit.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently when building the overview and guide files with Bazel, the following things are missing:
<!-- examplecomments with the corresponding HTML elements<div class="docs-markdown">elementAll of these points are handled with this commit.
Note: These points are taken from our current docs gulp task, but I removed some Regex transforms and just extended the default Markdown renderer to make these changes like they're supposed to.