Skip to content

build: increase saucelabs connect timeout #14470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

devversion
Copy link
Member

At some point we went down from a 2min wait timeout to 30seconds because we re-ran the startup script if something failed. Since re-running didn't really help and we removed it, we should move the timeout back to a longer period.

11 Dec 17:38:29 - Sauce Connect 4.5.2, build 4485 4a87b52 
11 Dec 17:38:29 - Using CA certificate bundle /etc/ssl/certs/ca-certificates.crt.
11 Dec 17:38:29 - Using CA certificate verify path /etc/ssl/certs.
11 Dec 17:38:29 - Starting up; pid 414
11 Dec 17:38:29 - Command line arguments: sauce-connect/bin/sc -u angular-ci -k **** --readyfile /tmp/material-saucelabs/readyfile --pidfile /tmp/material-saucelabs/pidfile --tunnel-identifier angular-material-25254-0 
11 Dec 17:38:29 - Log file: /tmp/sc-angular-material-25254-0.log
11 Dec 17:38:29 - Pid file: /tmp/material-saucelabs/pidfile
11 Dec 17:38:29 - Timezone: UTC GMT offset: 0h
11 Dec 17:38:29 - Using no proxy for connecting to Sauce Labs REST API.
11 Dec 17:38:31 - Started scproxy on port 40078.
11 Dec 17:38:31 - Please wait for 'you may start your tests' to start your tests.

// EXIT Timeout (30 seconds)

e.g. see: https://circleci.com/gh/angular/material2/25254 where it successfully acquired a tunnel, but just didn't have enough time to actually establish it.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 11, 2018
@devversion devversion requested a review from jelbourn as a code owner December 11, 2018 17:52
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 11, 2018
@devversion devversion force-pushed the build/increase-sl-connect-timeout branch from d9e002d to 5d3f538 Compare December 11, 2018 19:28
At some point we went down from a 2min wait timeout to 30seconds because we re-ran the startup script if something failed. Since re-running didn't really help and we removed it, we should move the timeout back to a longer period.

e.g. see: https://circleci.com/gh/angular/material2/25254 where it successfully acquired a tunnel, but just didn't have enough time to actually establish it.
@devversion devversion force-pushed the build/increase-sl-connect-timeout branch from 7167b45 to b62aeb7 Compare December 12, 2018 22:08
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 13, 2018
@vivian-hu-zz vivian-hu-zz merged commit c460728 into angular:master Dec 14, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
* build: increase saucelabs connect timeout

At some point we went down from a 2min wait timeout to 30seconds because we re-ran the startup script if something failed. Since re-running didn't really help and we removed it, we should move the timeout back to a longer period.

e.g. see: https://circleci.com/gh/angular/material2/25254 where it successfully acquired a tunnel, but just didn't have enough time to actually establish it.

* Switch to rewritten saucelabs version

* Update to latest saucelabs launcher version
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants