build: update circleci to latest nodejs version #14550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* We want to run CircleCI against the latest NodeJS docker image that also comes with the latest browsers. We currently just locked to a specific version because dgeni-packages was using a version of `nunjucks` that didn't work with the latest NodeJS version, * Updates dgeni-packages that supports a more recent TypeScript version might therefore be able to parse TS 3.x code that previously was silently ignored.
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
josephperrott
pushed a commit
to josephperrott/components
that referenced
this pull request
Jan 14, 2019
* We want to run CircleCI against the latest NodeJS docker image that also comes with the latest browsers. We currently just locked to a specific version because dgeni-packages was using a version of `nunjucks` that didn't work with the latest NodeJS version, * Updates dgeni-packages that supports a more recent TypeScript version might therefore be able to parse TS 3.x code that previously was silently ignored.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to run CircleCI against the latest NodeJS docker image that
also comes with the latest browsers. We currently just locked to a
specific version because dgeni-packages was using a version of
nunjucksthat didn't work with the latest NodeJS version,Updates dgeni-packages that supports a more recent TypeScript version
might therefore be able to parse TS 3.x code that previously was
silently ignored.