Skip to content

build: add script to publish release #14565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 19, 2018
Merged

build: add script to publish release #14565

merged 3 commits into from
Dec 19, 2018

Conversation

devversion
Copy link
Member

Closes #13455

@devversion devversion added in progress This issue is currently in progress pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 18, 2018
@devversion devversion self-assigned this Dec 18, 2018
@devversion devversion requested a review from jelbourn as a code owner December 18, 2018 20:25
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 18, 2018
jelbourn
jelbourn approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devversion
Copy link
Member Author

@jelbourn I've added the remaining changes I planned to add to this PR. Please have another look.

@devversion devversion force-pushed the build/release-create-script branch from 8c1f016 to 8360435 Compare December 19, 2018 19:27
@devversion devversion removed the in progress This issue is currently in progress label Dec 19, 2018
@devversion devversion mentioned this pull request Dec 19, 2018
Closed
jelbourn
jelbourn approved these changes Dec 19, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Dec 19, 2018
@ngbot
Copy link

ngbot bot commented Dec 19, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "branch-manager" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@jelbourn jelbourn merged commit fe7f95e into angular:master Dec 19, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@devversion @josephperrott
build: add script to publish release (angular#14565)
698929b 
Closes angular#13455
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve release process automation
3 participants
@devversion @jelbourn @googlebot