Skip to content

build: fix circleci branch filter not working #14583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2018
Merged

build: fix circleci branch filter not working #14583

merged 3 commits into from
Dec 20, 2018

Conversation

devversion
Copy link
Member

  • Due to some incorrect branch filter configuration, currently we publish build snapshots for all upstream branches (such as branches for quick reverts).

@jelbourn We should be good running the other jobs on upstream branches. I don't want to repeat this filters for each job... Unfortunately that's the only allowed way to filter for branches within CircleCI

@devversion
build: fix circleci branch filter not working
322c274 
* Due to some incorrect branch filter configuration, currently we publish build snapshots for *all* upstream branches (such as branches for quick reverts).
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 19, 2018
@devversion devversion requested a review from jelbourn as a code owner December 19, 2018 20:20
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 19, 2018
@devversion devversion added in progress This issue is currently in progress and removed in progress This issue is currently in progress labels Dec 19, 2018
@jelbourn
Copy link
Member

I would prefer to filter out all non-release branches even if it's a lot of boilerplate; the _presubmit branch in particular will otherwise cause a ton of jobs to be run.

@devversion devversion added the in progress This issue is currently in progress label Dec 19, 2018
@devversion
Copy link
Member Author

Caretaker note: When merging, please unmark the publish_snapshots job as required job in the repo settings.

@devversion devversion removed the in progress This issue is currently in progress label Dec 20, 2018
jelbourn
jelbourn approved these changes Dec 20, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 20, 2018
@jelbourn jelbourn merged commit 528dff5 into angular:master Dec 20, 2018
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@devversion @josephperrott
build: fix circleci branch filter not working (angular#14583)
e512e00
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot