Skip to content

build: add readme that marks schematics sources as internal #14596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2018
Merged

build: add readme that marks schematics sources as internal #14596

merged 1 commit into from
Dec 20, 2018

Conversation

devversion
Copy link
Member

In order to make clear that the sources/exports of the cdk/schematics directory are only intended for internal use, we should add a readme that makes this clear.

@devversion
build: readme that marks schematics sources as internal
8c93e95 
In order to make clear that the sources/exports of the `cdk/schematics` directory are only intended for internal use, we should add a readme that makes this clear.
@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Dec 20, 2018
@devversion devversion requested a review from jelbourn as a code owner December 20, 2018 18:39
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Dec 20, 2018
@devversion devversion changed the title build: readme that marks schematics sources as internal build: add readme that marks schematics sources as internal Dec 20, 2018
jelbourn
jelbourn approved these changes Dec 20, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Dec 20, 2018
@jelbourn jelbourn merged commit b12872e into angular:master Dec 20, 2018
@devversion devversion deleted the build/readme-schematics-internal branch December 20, 2018 18:44
josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 14, 2019
@devversion @josephperrott
build: readme that marks schematics sources as internal (angular#14596)
fd229d4 
In order to make clear that the sources/exports of the `cdk/schematics` directory are only intended for internal use, we should add a readme that makes this clear.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devversion @jelbourn @googlebot