refactor(drag-drop): clean up DragRef public API #14654
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
crisbeto
commented
Dec 27, 2018
| * Sets a handle as disabled. While a handle is disabled, it'll capture and interrupt dragging. | ||
| * @param handle Handle element that should be disabled. | ||
| */ | ||
| disableHandle(handle: HTMLElement) { |
There was a problem hiding this comment.
Note: I'm not too happy with having to add this method and enableHandle below, since it means having to do this above, however we need them in order to keep backwards compatibility. They allow us to handle the case where the user starts to drag from a disabled handle, in which case the dragging sequence should be interrupted. In the future we can reconsider whether supporting that case is worth it.
crisbeto
force-pushed
the
drag-ref-api-cleanup
branch
2 times, most recently
from
119499f to
011ba9a
Compare
jelbourn
approved these changes
Jan 9, 2019
src/cdk/drag-drop/directives/drag.ts
Outdated
| startWith(this._handles), | ||
| // Sync the new handles with the DragRef. | ||
| tap((handles: QueryList<CdkDragHandle>) => { | ||
| const ownHandles = handles.reduce((accumulator, handle) => { |
There was a problem hiding this comment.
I would do
const childHandleElements =
handles.filter(h => h._parentDrag === this).map(h => h.element);The number of handles will be trivially small
Cleans up the API of the DragRef before we can expose it through the public API by making the handle, custom placeholder and custom preview easier to configure.
crisbeto
force-pushed
the
drag-ref-api-cleanup
branch
from
011ba9a to
ff0faf9
Compare
s2-abdo
pushed a commit
to s2-abdo/material2
that referenced
this pull request
Jan 18, 2019
Cleans up the API of the DragRef before we can expose it through the public API by making the handle, custom placeholder and custom preview easier to configure.
s2-abdo
pushed a commit
to s2-abdo/material2
that referenced
this pull request
Jan 18, 2019
Cleans up the API of the DragRef before we can expose it through the public API by making the handle, custom placeholder and custom preview easier to configure.
vivian-hu-zz
pushed a commit
that referenced
this pull request
Jan 18, 2019
Cleans up the API of the DragRef before we can expose it through the public API by making the handle, custom placeholder and custom preview easier to configure.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the API of the DragRef before we can expose it through the public API by making the handle, custom placeholder and custom preview easier to configure.
Note: marking as merge safe, because all of the public API signature changes are to classes that haven't been exposed yet.