refactor: Prepare for TypeScript v3.2.2 #14847
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We're upgrading TypeScript to v3.2.2 in google3. This PR suppresses the compilation errors without actually upgrading the version of TypeScript. According to the comments, the top and bottom properties in ExtendedScrollToOptions are mutually exclusive. However when rewriting the bottom offset as a top offset both properties are defined. With the improved type inference in TypeScript 3.2 this is now a compilation error.
googlebot
added
the
cla: yes
crisbeto
added
pr: lgtm
action: merge
s2-abdo
pushed a commit
to s2-abdo/material2
that referenced
this pull request
Jan 18, 2019
We're upgrading TypeScript to v3.2.2 in google3. This PR suppresses the compilation errors without actually upgrading the version of TypeScript. According to the comments, the top and bottom properties in ExtendedScrollToOptions are mutually exclusive. However when rewriting the bottom offset as a top offset both properties are defined. With the improved type inference in TypeScript 3.2 this is now a compilation error.
vivian-hu-zz
pushed a commit
that referenced
this pull request
Jan 18, 2019
We're upgrading TypeScript to v3.2.2 in google3. This PR suppresses the compilation errors without actually upgrading the version of TypeScript. According to the comments, the top and bottom properties in ExtendedScrollToOptions are mutually exclusive. However when rewriting the bottom offset as a top offset both properties are defined. With the improved type inference in TypeScript 3.2 this is now a compilation error.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're upgrading TypeScript to v3.2.2 in google3. This PR suppresses the
compilation errors without actually upgrading the version of TypeScript.
According to the comments, the
topandbottomproperties inExtendedScrollToOptionsare mutually exclusive. However when rewritingthe bottom offset as a top offset both properties are defined. With the
improved type inference in TypeScript 3.2 this is now a compilation
error.