Skip to content

test(moment-adapter): use arabic locale for testing localized dates #14883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2019
Merged

test(moment-adapter): use arabic locale for testing localized dates #14883

merged 1 commit into from
Jan 23, 2019

Conversation

kdrvn
Copy link
Contributor

@kdrvn kdrvn commented Jan 18, 2019

Use a locale with localized date & year values different from the
English (default locale) values. Fix invalid tests description.

@kdrvn
test(moment-adapter): use arabic locale for testing localized dates
8913d81 
Use a locale with localized date & year values different from the
english (default locale) values. Fix invalid tests description.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 18, 2019
devversion
devversion approved these changes Jan 20, 2019
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me. Miles needs to review this.

@devversion devversion added pr: merge safe target: patch This PR is targeted for the next patch release labels Jan 20, 2019
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 22, 2019
@andrewseguin andrewseguin merged commit e2f68dc into angular:master Jan 23, 2019
@kdrvn kdrvn deleted the moment-adapter-tests branch January 24, 2019 07:07
andrewseguin pushed a commit that referenced this pull request Jan 25, 2019
@kdrvn @andrewseguin
test(moment-adapter): use arabic locale for testing localized dates (#…
a06dad1 
…14883)

Use a locale with localized date & year values different from the
english (default locale) values. Fix invalid tests description.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba mmalerba approved these changes

Assignees

@mmalerba mmalerba

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kdrvn @devversion @mmalerba @googlebot @andrewseguin